Skip to content

Extract application serializer #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2019
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 21, 2019

This resolves a few deprecation warnings from Ember Data about using the implicit default serializer which will be removed in the next major version release

r? @locks

This resolves a few deprecation warnings from Ember Data about using the implicit default serializer which will be removed in the next major version release
Copy link

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Rails starting doing this pattern with Rails 5, I think. would be good if we adopted this in ember by default, I think

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 21, 2019

@bors r=@NullVoxPopuli

@bors
Copy link
Contributor

bors commented Dec 21, 2019

📌 Commit 7078954 has been approved by NullVoxPopuli

@bors
Copy link
Contributor

bors commented Dec 21, 2019

⌛ Testing commit 7078954 with merge e9f071e...

bors added a commit that referenced this pull request Dec 21, 2019
Extract `application` serializer

This resolves a few deprecation warnings from Ember Data about using the implicit default serializer which will be removed in the next major version release

r? @locks
@bors
Copy link
Contributor

bors commented Dec 21, 2019

☀️ Test successful - checks-travis
Approved by: NullVoxPopuli
Pushing e9f071e to master...

@bors bors merged commit 7078954 into rust-lang:master Dec 21, 2019
@Turbo87 Turbo87 deleted the default-serializer branch December 21, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants